LinuxProcess: Resource adjustments#33
Merged
Merged
Conversation
Member
dcantah
commented
Jun 7, 2025
dcantah
commented
- The kqueue handlers for stdio didn't have logic to exit on zero byte reads.
- The agent wasn't getting closed explicitly in .delete()
- In LinuxContainer we should call delete just for sanity, if for nothing more than ensuring the agent vsock fd is closed.
adityaramani
reviewed
Jun 7, 2025
- The kqueue handlers for stdio didn't have logic to exit on zero byte reads. - The agent wasn't getting closed explicitly in .delete() - In LinuxContainer we should call delete just for sanity, if for nothing more than ensuring the agent vsock fd is closed. Signed-off-by: Danny Canter <danny_canter@apple.com>
dcantah
force-pushed
the
users/dcantah/linuxproc-adjustments
branch
from
f1b4b3e to
4ed789f
Compare
adityaramani
approved these changes
Jun 8, 2025
dkovba
added a commit
to dkovba/containerization
that referenced
this pull request
Mar 5, 2026
dkovba
added a commit
to dkovba/containerization
that referenced
this pull request
Mar 5, 2026
dkovba
added a commit
to dkovba/containerization
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.